search

orangehill / jstree-bootstrap-theme

Reponsive jsTree Twitter Bootstrap 3 Compatible Theme
MIT License
185 stars 93 forks source link

update for 3.2.1 #9

Open ranadeepak opened 8 years ago

ranadeepak commented 8 years ago

Hi I recently upgraded from jstree v3.1.1 to v3.2.1. I was using search plugin with 'show_only_matches' to true. With v3.1.1 it was not displaying the non matching nodes and displaying matching nodes with different css style. But after upgrade to v3.2.1 it is showing all the nodes and matching nodes in different css style.

Note: I am using the latest 'proton' theme avaliable in the repository.

For E.g. if I have following tree str: A\B\C\USA A\B\C\Germany A\B\D\USA2 A\D\India

and user searches for string 'US' the matching nodes were displayed: A\B\USA //with different css styling A\B\D\USA2 //with different css styling

But now the tree is displaying as: A\B\C\USA //with different css styling A\B\C\Germany A\B\D\USA2 //with different css styling A\D

This issue seems like the issue of css files we have. Any plan to update the css files?

vedraan commented 8 years ago

Hi, we did plan on updating the css files, as to add font-awesome support.

We will update the jsTree dependency as well and will try to look into the show_only_matches plugin problem if there is time.

So far we only really support styling for a couple of plugins you see on the demo and did not do any testing to see how the theme behaves with a wider range of plugins.

remygrandin commented 8 years ago

I had the same problem, found a (dirty) fix (https://github.com/vakata/jstree/issues/1414)