search

orangeshortstuff / PulsusSR

Pulsus - Short's Rework (for star rating / pulse)
MIT License
0 stars 2 forks source link

holds are treated as held beyond their actual duration #4

Closed orangeshortstuff closed 1 year ago

orangeshortstuff commented 1 year ago

in trying to test "sleepwalk station" (one of the newest maps, ID 11296), i noticed it had a far higher star rating than other maps of its gamma SR - at 1x, "obsessed" (ID 11373) has a star rating of ~3.05, while "sleepwalk station" has a far higher one, around ~4.59. when trying to track down the source of this, i found that the maximum length of the hold stack in this map was 28, far higher than should be possible (in reality, the actual max size should be 2 or 3) and even other, less "hold-heavy" maps have hold stack values far higher than make sense (obsessed has a max stack of 4, etyl a 12)

orangeshortstuff commented 1 year ago

bug fixed! issue was cause by an incorrect conversion to boolean on the "hold" item of each note