search

oras-project / oras-go

ORAS Go library
https://oras.land
Apache License 2.0
184 stars 99 forks source link

Replace deis references in annotations #4

Open jdolitsky opened 3 years ago

jdolitsky commented 3 years ago

See https://github.com/oras-project/oras-go/search?q=deis

cc @shizhMSFT

shizhMSFT commented 3 years ago

Any suggestions on the new annotation keys? /cc @SteveLasker

SteveLasker commented 3 years ago

How about cncf.oras.* What are these used for?

shizhMSFT commented 3 years ago

They are used for compressed directories. If we adopt https://github.com/oras-project/oras/issues/178, then we don't need to bother those annotations.

SteveLasker commented 3 years ago

Of course, I'd like to see #178, but I wouldn't block and seems you can use cncf.oras, however that does presume the project is accepted, so I'd suggest holding this annotation for now. It also makes it interesting how these would work if a new client is looking for cncf.oras and it discovers deis.oras? Are you thinking of maintaining some backwards compat?

bacongobbler commented 3 years ago

Is there a risk to users if these annotations are changed? As in, will Helm and other applications using oras be able to unpack charts using these annotations?

I'm okay with changing the annotation, but if it breaks something I'd like to know so we can inform users of breaking changes to helm chart push/helm chart pull in the next update.

jdolitsky commented 3 years ago

@bacongobbler Helm's use of oras-go (both the old version and the one in the HIP 6 PR) does not do anything with these annotations, so we are safe here

FeynmanZhou commented 2 years ago

I think we can add the website domain name as an option in annotations, then we have two options:

How about we vote one and then provide a backward compact solution? @SteveLasker @bacongobbler @shizhMSFT @sajayantony @yizha1