Closed ktarplee closed 9 months ago
This PR obviously still needs
@ktarplee Would you like to update this PR to reflect the latest discussion in #650?
@ktarplee Would you like to update this PR to reflect the latest discussion in #650?
I made the name change.
Attention: 6 lines
in your changes are missing coverage. Please review.
Comparison is base (
faaa1dd
) 75.41% compared to head (25e15fc
) 75.46%.
Files | Patch % | Lines |
---|---|---|
registry/remote/auth/cache.go | 82.35% | 4 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
I also added unit tests for the hostCache and exported NewSingleContextCache()
function. @shizhMSFT
@ktarplee LoL. The DCO check failed. Could you fix that?
This PR adds a new exported method called
NewRobustCache()
and changes theDefaultCache
to use the robust cache. The robust cache uses scoped based auth but falls back to host based auth to better handle the situations described in #650 but retain the benefits of scoped based auth (where the token for a repo might be different than another repo in the same registry).Closes #650