Closed sajayantony closed 8 months ago
All modified and coverable lines are covered by tests :white_check_mark:
Comparison is base (
0b78aa6
) 75.46% compared to head (fa2b729
) 75.46%.
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
On a side note, how what would be a good pattern to exclude full file examples from license header check?
Don't worry about the license headers. You can just add them in the source file and they will be ignored by godoc generation. Examples can be found at:
Using this PR to discuss the need for importing the hash algorithm. One option is that add this to the examples for digest or parse reference or it possible to have indirect dependencies. I'm leaning towards not having an indirect dependency since this means that if and when a algorithm becomes unacceptable the library has to rev. Instead clients taking the appropriate imports could define the actual hash algorithms that are being used - https://cloud-native.slack.com/archives/CJ1KHJM5Z/p1704365828594969
On a side note, how what would be a good pattern to exclude full file examples from license header check?
Related to - https://github.com/oras-project/oras-go/pull/671