search

oras-project / oras-go

ORAS Go library
https://oras.land
Apache License 2.0
179 stars 96 forks source link

feat: error type for not finding basic auth creds and export config path #674

Closed qweeah closed 9 months ago

qweeah commented 9 months ago

Two changes proposed in this PR 1) When failed to fetch credentials for basic auth, return a new error 2) Add a new function to DynamicStore

An example usage of the proposed change: oras-project/oras#1235, resolves #676

codecov[bot] commented 9 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Comparison is base (3b1dd0e) 75.71% compared to head (f1d1a3d) 75.78%.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #674 +/- ## ========================================== + Coverage 75.71% 75.78% +0.06% ========================================== Files 59 59 Lines 5765 5769 +4 ========================================== + Hits 4365 4372 +7 + Misses 1028 1026 -2 + Partials 372 371 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Wwwsylvia commented 9 months ago

I think this change is a feat instead of a chore as it introduces public types and methods.