oras-project / oras-go

ORAS Go library
https://oras.land
Apache License 2.0
168 stars 90 forks source link

docs: document PackManifestOptions to make PackManifest reproducible #749

Closed wangxiaoxuan273 closed 1 month ago

wangxiaoxuan273 commented 2 months ago

Resolves #748

codecov[bot] commented 2 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 77.92%. Comparing base (c071bed) to head (961075d).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #749 +/- ## ======================================= Coverage 77.92% 77.92% ======================================= Files 63 63 Lines 4694 4694 ======================================= Hits 3658 3658 Misses 656 656 Partials 380 380 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

Wwwsylvia commented 2 months ago

BTW, the PR title should start with docs (end with s) as per the conventional commit guidance. 😀

wangxiaoxuan273 commented 2 months ago

We also need to rephrase the related comment a bit for ExamplePackManifest_imageV10 and ExamplePackManifest_imageV11 in example_pack_test.go.

updated the comments in example_pack_test.go.