Open ADorigi opened 1 month ago
Hello @ADorigi , thank you for the PR! I just reviewed it and left some comments. By the way, can you follow Conventional Commits and rename the PR title to something like "feat: ..."?
Hi @Wwwsylvia
Please check the updates.
Now the check for non-tar file takes place in tfs.indexEntries()
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 78.03%. Comparing base (
c8c2048
) to head (51ec1d4
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Hi @ADorigi , the updated PR looks good overall. I left a few nit comments.
Hi @Wwwsylvia I made the minor changes and updated the error message.
cc @qweeah who opened the original issue
fixes #640
This pull request includes the following changes:
ErrNotTarFile
.tar
file