search

oras-project / oras-py

ORAS Python SDK
https://oras-project.github.io/oras-py/
Apache License 2.0
40 stars 36 forks source link

Make pyright happy #152

Open poksiala opened 2 months ago

poksiala commented 2 months ago

I tried to use this library and to be honest the user experience was not the best. For me it was hard to understand with all the missing and invalid type annotations. My editor was also complaining a lot, especially about the decorated methods that did not pass trough information about the methods.

So as an exercise to better understand the inner workings of the library I started to fix those type annotations. I also found some dead code and missing variables while doing that. Here are the results if you are interested in including them in the trunk.

This should not change the API at all though I have had no time to test it in actual use yet.

vsoch commented 1 month ago

@poksiala apologies this fell off my radar - if you want to rebase I can give another review and (I think) it should be ready for merge.