Closed wangxiaoxuan273 closed 2 months ago
Current display:
Attention: Patch coverage is 84.31373%
with 8 lines
in your changes are missing coverage. Please review.
Project coverage is 84.49%. Comparing base (
bb3443d
) to head (46bfbe3
).
Files | Patch % | Lines |
---|---|---|
cmd/oras/internal/option/remote.go | 89.74% | 3 Missing and 1 partial :warning: |
cmd/oras/root/login.go | 42.85% | 0 Missing and 4 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
-u xxx --identity-token xxx
usage should be banned, see https://github.com/oras-project/oras/issues/742#issuecomment-1398076477 <= just find this has already been resolved, good catch.
LGTM, created #1301 as a follow up so we can make the flag confliction check easier.
Can we resolve #1301 first and then this PR since it really simplifies the code a lot?
What this PR does / why we need it:
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #742Please check the following list: