Revert "bump(ci): update codecov gha to v4 (#1324)"

oras-project / oras

OCI registry client - managing content like artifacts, images, packages

https://oras.land

Apache License 2.0

1.44k stars 174 forks source link

Revert "bump(ci): update codecov gha to v4 (#1324)" #1333

Closed TerryHowe closed 5 months ago

TerryHowe commented 5 months ago

This reverts commit fb3adabb9e96e50d13aaa3290a946d063f8d7b8e.

What this PR does / why we need it:

github action broken. The codecov failure should succeed when this merges.

Which issue(s) this PR fixes Related https://github.com/oras-project/oras/issues/1291

qweeah commented 5 months ago

@TerryHowe Can we hold this PR from merging? We encountered consistent codecov upload failure in v3, which is also reproduced in this PR (see logs). We have already uploaded token to Github secrets so the main branch upload can pass.

The remaining piece is that we need to add this Codecov token to dependabot secrets as is suggested in https://github.com/codecov/codecov-action/issues/1292#issuecomment-1960681670. Will do it tomorrow and that will fix the dependabot PR failure.

shizhMSFT commented 5 months ago

@TerryHowe I've added the token to the dependabot and it works now.

shizhMSFT commented 5 months ago

Please re-open the PR if you find anything wrong again.