oras-project / oras

OCI registry client - managing content like artifacts, images, packages
https://oras.land
Apache License 2.0
1.43k stars 174 forks source link

refactor: Pass printer to text handler #1420

Closed TerryHowe closed 3 months ago

TerryHowe commented 3 months ago

What this PR does / why we need it:

Pass printer object to text handler.

I'm going to explore the possibility of passing the printer to the json and template handler, but trying to keep this small.

codecov[bot] commented 3 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.32%. Comparing base (37941a0) to head (c96490c).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1420 +/- ## ========================================== - Coverage 85.33% 85.32% -0.01% ========================================== Files 106 106 Lines 3798 3810 +12 ========================================== + Hits 3241 3251 +10 - Misses 333 334 +1 - Partials 224 225 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

qweeah commented 3 months ago

I'm going to explore the possibility of passing the printer to the json and template handler, but trying to keep this small.

Making printer implement io.Writer should help.