search

oras-project / oras

OCI registry client - managing content like artifacts, images, packages
https://oras.land
Apache License 2.0
1.52k stars 181 forks source link

refactor: Isolate progress channel in Messenger #1447

Closed TerryHowe closed 4 months ago

TerryHowe commented 4 months ago

What this PR does / why we need it:

Isolate details about the progress channel from users

codecov[bot] commented 4 months ago

Codecov Report

Attention: Patch coverage is 92.30769% with 4 lines in your changes missing coverage. Please review.

Project coverage is 85.42%. Comparing base (cdb60fc) to head (769aeb2).

Files Patch % Lines
...oras/internal/display/status/progress/messenger.go 88.88% 3 Missing and 1 partial :warning:
Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1447 +/- ## ========================================== - Coverage 85.47% 85.42% -0.06% ========================================== Files 108 109 +1 Lines 3827 3841 +14 ========================================== + Hits 3271 3281 +10 - Misses 333 336 +3 - Partials 223 224 +1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

qweeah commented 4 months ago

BTW @TerryHowe Good job, this is an elegant refactoring!