search

oras-project / oras

OCI registry client - managing content like artifacts, images, packages
https://oras.land
Apache License 2.0
1.52k stars 181 forks source link

fix: variable name conflicts with built in function #1448

Closed TerryHowe closed 4 months ago

TerryHowe commented 4 months ago

What this PR does / why we need it:

The variable name len conflicts with the built in. This will simplify my other PR a bit as well.

codecov[bot] commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 85.52%. Comparing base (9e5e766) to head (c3e5944).

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1448 +/- ## ========================================== + Coverage 85.47% 85.52% +0.05% ========================================== Files 108 108 Lines 3827 3827 ========================================== + Hits 3271 3273 +2 + Misses 332 331 -1 + Partials 224 223 -1 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

qweeah commented 4 months ago

Added a unit test to cover the missing line, but I have wrongly pushed to #1447. Guess this should be merged first and merging #1447 will save that fault.