oras-project / oras

OCI registry client - managing content like artifacts, images, packages
https://oras.land
Apache License 2.0
1.52k stars 181 forks source link

fix(ut,windows): exclude pty build in Windows tests #1541

Closed qweeah closed 1 week ago

qweeah commented 1 week ago

What this PR does / why we need it:

Which issue(s) this PR fixes (optional, in fixes #<issue number>(, fixes #<issue_number>, ...) format, will close the issue(s) when PR gets merged): Fixes #1540

Please check the following list:

codecov[bot] commented 1 week ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 83.99%. Comparing base (4996e1f) to head (8c4f52a). Report is 1 commits behind head on main.

Additional details and impacted files ```diff @@ Coverage Diff @@ ## main #1541 +/- ## ======================================= Coverage 83.99% 83.99% ======================================= Files 119 119 Lines 5306 5306 ======================================= Hits 4457 4457 Misses 602 602 Partials 247 247 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

qweeah commented 1 week ago

Yes, just build failure. I will take a look at #1474 later this week to unblock you.

TerryHowe commented 1 week ago

Closes: https://github.com/oras-project/oras/issues/1540