Closed Wwwsylvia closed 2 days ago
Attention: Patch coverage is 92.85714%
with 3 lines
in your changes missing coverage. Please review.
Project coverage is 83.98%. Comparing base (
0483d7b
) to head (bedfd51
). Report is 1 commits behind head on main.
Files with missing lines | Patch % | Lines |
---|---|---|
cmd/oras/root/manifest/push.go | 57.14% | 1 Missing and 2 partials :warning: |
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
There are 17 commands that support verbose and this PR reduces that to 10 which is technically a breaking change, right?
Indeed, it is technically a breaking change.
But the idea is that the verbose
flag makes no difference on the output of the rest of 10 commands, so the existence of the flag is more like a bug instead of a feature for those commands. This change aims to fix the bug.
What this PR does / why we need it:
verbose
flag out ofopts.Common
verbose
flags to the following commands:oras push
oras pull
oras attach
oras cp
oras manifest push
oras blob push
oras discover
Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes part of #1533Please check the following list: