Open Wwwsylvia opened 1 day ago
All modified and coverable lines are covered by tests :white_check_mark:
Project coverage is 84.04%. Comparing base (
2703462
) to head (4680d74
).
:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.
Maybe mark it deprecated in the Printer object too
Maybe mark it deprecated in the Printer object too
Currently it is still functioning, we can consider removing the whole verbose stuff in v1.4.0 or something? From my understanding, the printer will be refactored by @wangxiaoxuan273 soon as part of handler refactoring.
@TerryHowe This is now ready for review.
What this PR does / why we need it:
Mark the
--verbose
flag as deprecated and print verbose output by default for the following six commands. As a result, the--verbose
flag will be hidden in the help doc, and there will be a warning message when--verbose
is specified.oras push
oras pull
oras attach
oras cp
oras manifest push
oras blob push
Add the corresponding E2E tests
The deprecation of
--verbose
fororas discover
will be addressed with #1534.Which issue(s) this PR fixes (optional, in
fixes #<issue number>(, fixes #<issue_number>, ...)
format, will close the issue(s) when PR gets merged): Fixes #1533 Prerequisite: #1553Examples:
oras pull
BEFORE:oras pull
AFTER:oras pull --verbose
BEFORE:oras pull --verbose
AFTER:oras pull --verbose=false
BEFORE:oras pull --verbose=false
AFTER:oras pull --help
BEFORE:oras pull --help
AFTER:Please check the following list: