search

oras-project / rust-oci-client

A Rust crate to interact with OCI registries
Apache License 2.0
93 stars 49 forks source link

Pull alternative urls #108

Closed seanyoung closed 8 months ago

seanyoung commented 8 months ago

This helps with pulling this image mcr.microsoft.com/windows/nanoserver/insider:10.0.20348.1

seanyoung commented 8 months ago

Thank you the quick response! This is good to go. Since this is a breaking API change, we'll release this in the 0.11 release

Thanks! I've fixed the needless borrow warnings, needs approval again. I suspect the test failure was just an intermittent failure

thomastaylor312 commented 8 months ago

Hmmm really odd test failure:

thread 'client::test::test_mount' panicked at src/client.rs:2671:14:
Failed to mount: SpecViolationError("Expected HTTP Status 201 Created, got 202 Accepted instead")

@seanyoung you seeing this locally as well? Gonna pull down this branch and try

thomastaylor312 commented 8 months ago

It does look like the spec says it should be returning 201: https://github.com/opencontainers/distribution-spec/blob/main/spec.md#endpoints. Tests work on main though, so I'm looking into this

flavio commented 8 months ago

@thomastaylor312 I would go ahead and merge this PR if you're fine with that