oras-project / rust-oci-client

A Rust crate to interact with OCI registries
Apache License 2.0
93 stars 49 forks source link

ref(client): Debug, Eq, Hash, PartialEq for ImageLayer; convert annotations to BTreeMap #121

Closed vdice closed 6 months ago

vdice commented 6 months ago

Changeset motivated by the need to differentiate and deduplicate collections of ImageLayers.

thomastaylor312 commented 6 months ago

@vdice heads up that it looks like the BTreeMap import didn't get picked up in the windows build for some reason

vdice commented 6 months ago

@thomastaylor312 thanks - looks like I didn't update the import in examples/wasm/push.rs. Now updated; hopefully that was the issue.

edit: nope; still failing... looking

edit 2: okay, needed to update examples/wasm/main.rs as well. Weird - nothing complained when I ran my usual just build && just test flow... but once I started running the cargo test command from the justfile-windows file, I was able to repro. Turns out the warnings also occur on main, but at least there should be no error now.

thomastaylor312 commented 6 months ago

Thanks for soldering through that @vdice. Just waiting on a second opinion from @flavio on the breaking aspect of this

flavio commented 6 months ago

Sorry, I was on vacation. This change looks good to me

vdice commented 6 months ago

Thanks so much @thomastaylor312 and @flavio!