oravirt / ansible-oracle-modules

Oracle modules for Ansible
MIT License
214 stars 159 forks source link

oracle_stats_prefs: Python 3.7 issue #88

Open matthiaslink77 opened 5 years ago

matthiaslink77 commented 5 years ago

oracle_stats_prefs running with Python 3.7 leads to the following syntax error:

ansible 2.7.5 config file = /home/matlink/.ansible.cfg configured module search path = ['/home/matlink/.ansible/plugins/modules', '/usr/share/ansible/plugins/modules'] ansible python module location = /usr/lib/python3.7/site-packages/ansible executable location = /usr/bin/ansible python version = 3.7.2 (default, Jan 16 2019, 19:49:22) [GCC 8.2.1 20181215 (Red Hat 8.2.1-6)]

TASK [set dbms_stats settings] *** The full traceback is: Traceback (most recent call last): File "/usr/lib/python3.7/site-packages/ansible/executor/task_executor.py", line 140, in run res = self._execute() File "/usr/lib/python3.7/site-packages/ansible/executor/task_executor.py", line 612, in _execute result = self._handler.run(task_vars=variables) File "/usr/lib/python3.7/site-packages/ansible/plugins/action/normal.py", line 46, in run result = merge_hash(result, self._execute_module(task_vars=task_vars, wrap_async=wrap_async)) File "/usr/lib/python3.7/site-packages/ansible/plugins/action/init.py", line 738, in _execute_module (module_style, shebang, module_data, module_path) = self._configure_module(module_name=module_name, module_args=module_args, task_vars=task_vars) File "/usr/lib/python3.7/site-packages/ansible/plugins/action/init.py", line 177, in _configure_module environment=final_environment) File "/usr/lib/python3.7/site-packages/ansible/executor/module_common.py", line 973, in modify_module environment=environment) File "/usr/lib/python3.7/site-packages/ansible/executor/module_common.py", line 791, in _find_module_utils recursive_finder(module_name, b_module_data, py_module_names, py_module_cache, zf) File "/usr/lib/python3.7/site-packages/ansible/executor/module_common.py", line 538, in recursive_finder tree = ast.parse(data) File "/usr/lib64/python3.7/ast.py", line 35, in parse return compile(source, filename, mode, PyCF_ONLY_AST) File "", line 153 except cx_Oracle.DatabaseError, exc: ^ SyntaxError: invalid syntax

fatal: [hostname]: FAILED! => { "msg": "Unexpected failure during module execution.", "stdout": "" }

while running with Python 2.7, this works fine.

We already has similar issues with other modules as well. Can you please ask Mikael how he fixed it?

Thanks a lot and best regards, Matthias.

oravirt commented 5 years ago

https://github.com/oravirt/ansible-oracle-modules/commit/10a45566eed9a9d78ac53598d307910c2a071e50 should fix this.