search

oraxen / oraxen

Oraxen is a minecraft plugin that allows to easily use Minecraft 1.14 features in order to create new items with custom textures. It handles the resourcepack generation, upload (using Polymath) and has an extensible API.
https://docs.oraxen.com/
Other
619 stars 314 forks source link

[BUG] Excelent Enchants not able to apply enchantments while Oraxen is loaded #1528

Closed LadyHaley closed 2 days ago

LadyHaley commented 1 month ago

I have checked...

Description

Whille the plugins EnchantGui, ExcellentEnchants, LibsDisguises, nightcore, Oraxen, packetevents, ProtocolLib are installed, Excellent Enchants cannot apply enchantment to items outside of using commands. Removing Oraxen is the only thing that fixes this bug I booted a fresh server with new configs and got the same result as my testing and live servers

EnchantGui - 3.9.1 ExcellentEnchants- 4.2.2 LibsDisguises - v10.0.44-SNAPSHOT-b1450 nightcore - v2.6.3-updated 29th July packetevents - 2.5.0+738d429-SNAPSHOT

Steps to reproduce

install plugins onto server result

Plugin Version

1.181.0

ProtocolLib Version

5.3.0-SNAPSHOT-726

Server Software & Version

This server is running Paper version 1.21.1-97-master@acdd6d3 (2024-09-23T22:14:51Z) (Implementing API version 1.21.1-R0.1-SNAPSHOT)\nYou are running the latest version

How breaking is the bug?

Non-breaking Bug - Plugin still usable, but certain features unavailable

LadyHaley commented 1 month ago

I realised on the test server I used the last version of oraxen, not latest, redid the test, same result

LadyHaley commented 1 month ago

image This error shows up only when oraxen is installed

LadyHaley commented 4 weeks ago

Any insight as to why this is occurring? it only happens with Oraxen installed :c

thatpris commented 2 weeks ago

After some testing, only when Oraxen, Protocolib, PacketEvents and ExcellentEnchants are all present together would the error occur. My bet is that the anvil-changing behaviour codes of the two plugins are clashing together. Oraxen dev if you can look into this ASAP I would be glad.

thatpris commented 2 weeks ago

Removing either packetevents or protocolib seems to fix the error, this may shine some light?

Boy0000 commented 1 week ago

unable to reproduce this with oraxen and Excellent enchants, if protlib or packetevents fixes it its a clash there Oraxen relies on protocollib and might cause issues if you have both plugins If someone can consistently reproduce this with only the relevant plugins lmk, if this is an issue of packetevents + protocollib, i cant fix it

https://github.com/user-attachments/assets/e57601d6-064c-42e9-a91f-fc71721bf379

thatpris commented 6 days ago

You were using Creative Mode. Use Survival Mode and the error will occur. After further testing, it seems that this issue is unrelated to PacketEvents. Even with only Oraxen/Protocolib present, the bug occurs.

https://github.com/user-attachments/assets/dc0f2a09-4e54-4a80-9670-d6598519675e

Boy0000 commented 2 days ago

Tracked it down to CommandAPI, so it is not Oraxen I'll try and find a solution but yeah, seems to be something there

image image

Boy0000 commented 2 days ago

~Has been tracked down to how this plugin works and registers enchantments in a Spigot way not Paper way / datapack Not CommandAPI, ProtocolLib or anything like that here, would be on ExcellentEnchants to fix~ @thatpris @LadyHaley

Workaround in Oraxen has been found

image

thatpris commented 2 days ago

~Has been tracked down to how this plugin works and registers enchantments in a Spigot way not Paper way / datapack Not CommandAPI, ProtocolLib or anything like that here, would be on ExcellentEnchants to fix~ @thatpris @LadyHaley

Workaround in Oraxen has been found

image

great! how soon can I expect the workaround/fix?

Boy0000 commented 2 days ago

great! how soon can I expect the workaround/fix?

next update and devbuilds soon if ur compiling / in the discord