search

orbbec / OrbbecSDK-K4A-Wrapper

This repo is forked from Azure-kinect-Sensor-SDK，contain the K4A wrapper for OrbbecSDK.
https://www.orbbec.com/
MIT License
24 stars 7 forks source link

Turning the LED on and off works in reverse #42

Closed Rudizzzz closed 3 months ago

Rudizzzz commented 4 months ago

Describe the bug

The Microsoft.Azure.Kinect.Sensor.DeviceConfiguration.DisableStreamingIndicator works in reverse. If I set this parameter = true, the led turns on. If I set this parameter = false, the led turns off.

To Reproduce

  1. Initialize a DeviceConfiguration object where DisableStreamingIndicator = true.
  2. Start the camera
  3. Check the led status
  4. Stop the camera
  5. Initialize a DeviceConfiguration object where DisableStreamingIndicator = false.
  6. Start the camera
  7. Check the led status

Expected behavior

Since the name of the parameter is DisableStreamingIndicator, not EnableStreamingIndicator, the led should turn off if the parameter = true and turn on if the parameter = false. The Kinect 4 Azure SDK works fine, so this fix is important to preserve backward compatibility.

Logs

Screenshots

Desktop (please complete the following information):

Additional context

ChuckM90 commented 4 months ago

Maybe it could have been solved here #43

Rudizzzz commented 4 months ago

Yes, I'll wait for the official release then. Thanks

zhonghong322 commented 4 months ago

The code has been modified and committed to the develop branch（https://github.com/orbbec/OrbbecSDK-K4A-Wrapper/commits/develop/）. Going forward, new features will be added, and they will be released together in a future version.

zhonghong322 commented 3 months ago

The k4a wrapper 1.9.2 has been fixed and release.