search

orbbec / OrbbecSDK-K4A-Wrapper

This repo is forked from Azure-kinect-Sensor-SDK，contain the K4A wrapper for OrbbecSDK.
https://www.orbbec.com/
MIT License
24 stars 7 forks source link

corrupt ZIP download for v1.9.2 for Windows #52

Open diablodale opened 3 months ago

diablodale commented 3 months ago

Your download for v1.9.2 for Windows is corrupt and must not be used. Please recreate your ZIP download for Windows and re-upload it for distribution. Please also improve your test and release processes to verify distributions before uploading.

Repro

This was reproduced using both a Windows 11 and a Ubuntu computer.

  1. Download https://github.com/orbbec/OrbbecSDK-K4A-Wrapper/releases/download/v1.9.2/OrbbecSDK_K4A_Wrapper_v1.9.2_windows_64_release_2024_03_06.zip
  2. Unzip this file

Result

Most of the header files are corrupt. This is a list of the corrupts files I found. There may be more.

grep -R TSD-Header *
Binary file include/k4a/k4a.h matches
Binary file include/k4a/k4a.hpp matches
Binary file include/k4a/k4atypes.h matches
Binary file include/k4a/k4aversion.h matches
Binary file include/k4a/k4a_export.h matches
Binary file include/k4arecord/k4arecord_export.h matches
Binary file include/k4arecord/playback.h matches
Binary file include/k4arecord/playback.hpp matches
Binary file include/k4arecord/record.h matches
Binary file include/k4arecord/record.hpp matches
Binary file include/k4arecord/types.h matches

Instead of header C code, they have binary content like:

%TSD-Header-###%��H������e%i9�@K��

Expected

Correct C/C++ headers

zhonghong322 commented 3 months ago

thank you for feedback the issue. The issue has been fixed.

diablodale commented 3 months ago

glad to read that you have fixed your CI and included tests to verify your binaries BEFORE giving to customers. I look forward to this never repeating since "The issue has been fixed."