Use history API to handle browser back - Githubissues

orbeon / orbeon-forms

Orbeon Forms is an open source web forms solution. It includes an XForms engine, the Form Builder web-based form editor, and the Form Runner runtime.

http://www.orbeon.com/

GNU Lesser General Public License v2.1

516 stars 221 forks source link

Use history API to handle browser back #1802

Closed ebruchez closed 5 years ago

ebruchez commented 10 years ago

Right now we use hidden fields, which are error prone, see #1789.

~~Use polyfill or current method for old browsers, and history API.~~

ebruchez commented 8 years ago

The history API is supported since IE 10. See also #2651.

See also history.js and HTML5-History-API as polyfills.

ebruchez commented 6 years ago

No need for polyfills anymore.

ebruchez commented 5 years ago

Right now, things work like this:

upon page load
- App.main() registers DOM ready handler
upon DOM ready
- App.loadAndInit() runs
- calls Init.document(), which is implemented in JavaScript
document()
- for all .xforms-form, find $... form fields ($uuid, $static-state, $dynamic-state, $server-events, $client-state, $repeat-tree, $repeat-indexes)
- store values into ORBEON.xforms.Globals
- $client-state is handled specially

What do do with all those:

[x] $uuid
- doesn't mutate in theory except restored when state is restored
- needed for 2-pass submission
[x] $static-state, $dynamic-state: not used for server state handling
[x] $server-events: needed for 2-pass submission
[x] $client-state: replace with history API
[x] $repeat-tree, $repeat-indexes: don't use hidden fields, see also #2892

ebruchez commented 5 years ago

$client-state is type="text" and hidden via CSS. All other $... fields are type="hidden".

ebruchez commented 5 years ago

Liferay:

How does this interact with Liferay's SPAs and other?
Entered #4127.

ebruchez commented 5 years ago

[x] handle initial load if state exists, for example after restart of server
[x] move to separate StateHandling object
[x] update other uses of replaceState to keep current state
[ ] review sequence of operations: order should guarantee that things work without callback from dynamic XForms (initializeFormWithInitData)?
[x] REGRESSION: navigate to Review page, back, forward: Review page appears as Edit page (Chrome)!
- Entered #4126.
[ ] document behavior of Cmd-Enter in URL bar vs. reload, etc. with various browsers

ebruchez commented 5 years ago

Status of the above noted regression:

I still reproduce the regression it with Chrome.
With Safari, the browser appears to cache everything and things work ok.
With Firefox, the page is restored as expected (with all the init, events, etc.)

ebruchez commented 5 years ago

This seems to happen only if we POST from the new or edit page to the review page and then back/forward. The issue happens only on forward.