Update to `scalajs-dom` 2.8.0 or newer

orbeon / orbeon-forms

Orbeon Forms is an open source web forms solution. It includes an XForms engine, the Form Builder web-based form editor, and the Form Runner runtime.

http://www.orbeon.com/

GNU Lesser General Public License v2.1

512 stars 220 forks source link

Update to `scalajs-dom` 2.8.0 or newer #5049

Open ebruchez opened 2 years ago

ebruchez commented 2 years ago

Tried this but there is an issue: scalajs-jquery is not compiled against 2.0.0 so this doesn't compile. Specifically, JQueryEventObject causes problems. We'll need scalajs-jquery (or other) compiled against 2.0.0.

Work in progress on local wip-5049-scalajs-dom-20 branch.

ebruchez commented 2 years ago

The scalajs-jquery we use (https://github.com/sjrd/scala-js-jquery/commits/master) is not ~~really~~ maintained anymore, and not even linked from the Scala.js site. Instead:

https://github.com/jducoeur/jquery-facade: newer but no recent release
https://github.com/UdashFramework/scala-js-jquery: appears up to date, with version ~~3.2.0~~ 3.3.0 depending on scalajs-dom ~~2.0.0~~ 2.7.0

ebruchez commented 1 year ago

See also #5433.

ebruchez commented 1 year ago

Not sure about the Udash version now as it hasn't been updated in a year.

ebruchez commented 8 months ago

There have been two releases in 2023: 3.2.0 and 3.3.0. JQuery doesn't change often and we are reducing our dependence on it anyway, so hopefully this should be fine.

avernet commented 2 months ago

+1 from me, to use HTMLDialogElement, already added in 2.3 (released in August 2022).