orbeon / orbeon-forms

Orbeon Forms is an open source web forms solution. It includes an XForms engine, the Form Builder web-based form editor, and the Form Runner runtime.
http://www.orbeon.com/
GNU Lesser General Public License v2.1
514 stars 220 forks source link

Add a mechanism to stop LifecycleLogger.scala from logging out value of JSESSIONID #5288

Open aasaru opened 2 years ago

aasaru commented 2 years ago

Orbeon logs out value of JSESSION id cookie:

2022-03-25 08:52:48,458 org.orbeon.oxf.logging.LifecycleLogger$.event(LifecycleLogger.scala:103) INFO lifecycle - event: {"request": "1", "session": "EB57E453E2A45DFB5256F82031F60D87", "source": "service", "message": "start: handle"}

According to OWASP v4.0.3 V7.1.1:

Verify that the application does not log credentials or payment details. Session tokens should only be stored in logs in an irreversible, hashed form.

Problem is that whoever has access to logs could take over user's session.

Possible solutions:

ebruchez commented 2 years ago

I think that's a reasonable suggestion.