search

orbeon / orbeon-forms

Orbeon Forms is an open source web forms solution. It includes an XForms engine, the Form Builder web-based form editor, and the Form Runner runtime.
http://www.orbeon.com/
GNU Lesser General Public License v2.1
514 stars 221 forks source link

Add tooltip for "x" in title bar of dialogs #6271

Closed avernet closed 2 months ago

avernet commented 5 months ago

To reproduce, run the All Form Controls example, on the first page change the password, go to the last page, click Review, the Review Form Validation Messages dialog shows, mouse over the "x" in the dialog title bar, notice that no tooltip shows.

This is still using the YUI dialog, which generates <a class="container-close" href="#">Close</a>. We should switch away from the YUI, maybe to the Bootstrap dialog, so we can control this better (with the existing markup we would like to add a title="Close") and use a Form Runner resource.

Currently, this dialog is shown by showDialog in XFormsUI.scala.

+1 from customer

avernet commented 2 months ago

Closing, for now, as for 2024.1, with the switch to <dialog> (#2835), we're tentatively not putting an "x" on the title bar, relying on the clickable "Close" link, but still support esc shortcut.