Configuration banner shows for custom persistence provider

[ebruchez]

The reason is that we check all active providers, then make sure that there is a datasource configured for that provider. However, an external provider, only identified by URI with oxf.fr.persistence.my-provider.uri, should not have its datasource checked.

So somehow we must exclude such external providers.

+1 from customer

[ebruchez]

We could consider that providers with an absolute URL are external and should not be datasource-checked.

Or we could consider that providers that match known internal URLs are internal and should be datasource-checked.

[avernet]

We could consider that providers with an absolute URL are external and should not be datasource-checked.

@ebruchez Wouldn't this technique fail to exclude the filesystem provider, which doesn't have a data source?

[ebruchez]

We don't really have a filesystem provider: we have it only for attachments, and the configuration property for that looks different:

oxf.fr.persistence.provider.*.*.*.attachments

[avernet]

Try adding the property. That provider will end up in activeInternalProviders, and then in problematicDataSources since it doesn't have a datasource.

<property as="xs:string" name="oxf.fr.persistence.provider.*.*.*.attachments" value="filesystem"/>

[ebruchez]

+1 from customer for a related issue where the filesystem provider causes the banner to show.

[ebruchez]

New fix, with more unit tests!