Form Builder unresponsive after "Undeclared variable in XPath expression"

orbeon / orbeon-forms

Orbeon Forms is an open source web forms solution. It includes an XForms engine, the Form Builder web-based form editor, and the Form Runner runtime.

http://www.orbeon.com/

GNU Lesser General Public License v2.1

518 stars 220 forks source link

Form Builder unresponsive after "Undeclared variable in XPath expression" #6517

Open avernet opened 2 months ago

avernet commented 2 months ago

Import form.txt.
Open the Control Settings for the 3rd control, Databound with search.
Set Open selection to Formula, type $is-open.
Apply ⇒ "Undeclared variable in XPath expression: $is-open".

ebruchez commented 1 month ago

The issue appears to be this:

we have an AVT with selection="{if ($is-open) then 'open' else ''}"
variables are not supported directly on view attributes
but we replace this in controls.xsl with calls to functions to retrieve a control's value
however, controls.xsl, included by components.xsl, does not run at design-time

Thoughts:

we could run controls.xsl or a subset at design-time
but this should probably not evaluate at design-time anyway, in the same way that we do not run calculations or validations at design-time

ebruchez commented 1 month ago

In annotate-design-time.xsl, we handle specifically fr:section/(@open | @readonly | @page-size), for example, in addition to MIPs. The attributes are moved to the fb: namespace. We should do something similar here. In addition, the control editor should use the fb: namespace when reading/updating attributes.

ebruchez commented 1 month ago

We can also check within the component itself whether we are at design-time when calling fr:component-param-value('selection'). Could we also make a static determination? That is, if literally true, when we are open, but if an AVT, then "maybe" or "closed"?