Lost "+" (Add another line to the repeated grid) for multiline repeats

orbeon / orbeon-forms

Orbeon Forms is an open source web forms solution. It includes an XForms engine, the Form Builder web-based form editor, and the Form Runner runtime.

http://www.orbeon.com/

GNU Lesser General Public License v2.1

518 stars 220 forks source link

Lost "+" (Add another line to the repeated grid) for multiline repeats #6622

Open avernet opened 2 weeks ago

avernet commented 2 weeks ago

This regressed between 2023.1.3 and 2023.1.4, most likely with #4491. To reproduce use http://localhost:8080/orbeon/fr/orbeon/repeated-grids/new.

✅ With 2023.1.3:

❎ With 2023.1.4:

+1 from customer +1 from customer

ebruchez commented 2 weeks ago

when fixing #4491, I also fixed the handling of grid borders, which were inconsistent
while doing so, I decided that having a "+" on an otherwise empty line was not elegant

We could re-add the "+", but in general it doesn't look too good. Can we figure out something better? Maybe the "+" should be in each iteration, under the menu? There should be enough space since this happens only when iterating over more than one row.

ebruchez commented 1 week ago

RESOLUTION: We fix this for 2023.1.6.