No success or error message when encountering issue saving with custom provider

[avernet]

To reproduce:

• gh gist clone 3c72973b745b73ecb30af487bc82cdea 6639
• cd 6639
• docker compose up -d
• http://localhost:8080/orbeon/fr/orbeon/bookshelf/new
• Enter a title and an author, hit Save
• ⇒ No success or error message shows

+1 from customer

[ebruchez]

I reproduce this. I see that the persistence proxy returns the error correctly, and that the ProcessInterpreter obtains the error as well. The issue appears to be in running the process continuation.

[ebruchez]

Interestingly, we process this:

(nop then new-to-edit then success-message("save-success") recover error-message("database-error"))

This decomposes into a (expr, rest), where rest is Nil. This later causes the code not to execute rest.

But removing parentheses:

nop then new-to-edit then success-message("save-success") recover error-message("database-error")

returns a different (expr, rest) tuple, with rest being non-empty.

[ebruchez]

• [x] fix
• [x] test

[ebruchez]

Assuming continue-with-failure is an action that fails:

continue-with-failure then (a then b recover c)

produces a result different from:

continue-with-failure then a then b recover c

This is by design. Parentheses create groups or blocks.