orbisgis / geoclimate

Geospatial processing toolbox for environmental and climate studies
GNU Lesser General Public License v3.0
59 stars 15 forks source link

JOSS review: Paper #622

Closed arbennett closed 2 years ago

arbennett commented 2 years ago

Paper review of "GeoClimate: a Geospatial processing toolbox for environmental and climate studies" by Erwan Bocher et al.

Summary comments

The summary opens with describing how human land use and land cover change modify climate, but when introducing GeoClimate the connection isn't entirely clear. Particularly I think an even broader "lead-in" of what GeoClimate is. From only reading the summary I understand that GeoClimate provides data, but is it's main purpose to gather and synthesize the data to usable formats, or is it more of a tool where a user brings their own data?

All of this is answered in paragraphs 2 and 3 of the statement of need section, but I think a couple of high level sentences in the summary would be nice.

Processing steps comments

On point 1, I was confused by "represented by 2.5 geometries". Do these geometries represent specifc features like the walls and roof or something else? Why the half geometry (and what does that actually mean)?

I found the discussion of the block and RSU spatial units (lines 83-91) a bit confusing. What are each used for? Are both only considering 2D, and do both share the same minimum sizes for partitioning of water and vegetation?

Minor comments

Line 27: Should teb be in parentheses? Line 27: "(ii) more sophisticated ones" -> does "ones" refer to parameters? Figure 5: I think it would be helpful to say "Sky View Factor (SVF)" rather than just SVF, since that's only mentioned in a footnote previously

ebocher commented 2 years ago

Thanks for the comments we'll process them quickly

ebocher commented 2 years ago

@j3r3m1 @ELSW56 @gpetit @franetibe @SPalominos

ebocher commented 2 years ago

Thanks @omshinde for the review.

https://github.com/openjournals/joss-reviews/issues/3541#issuecomment-917406606

ebocher commented 2 years ago

@arbennett , @omshinde All comments have been fixed in the paper and a new version with the changes is available here https://github.com/orbisgis/geoclimate/suites/3773956828/artifacts/92897033

ebocher commented 2 years ago

Closed