orbisgis / geoclimate

Geospatial processing toolbox for environmental and climate studies
GNU Lesser General Public License v3.0
59 stars 16 forks source link

json config file - proposal for enhancement #755

Closed simogeo closed 2 years ago

simogeo commented 2 years ago

According to me, locations should not be nested in folder key but at the same level because it is not (or should not be) dependent from the dataset.

Now :

"input": {
        "folder": {"path": "C:\\mydirectory\\Geoclimate\\BD_TOPO_v2",
                   "locations":["12174"]
         }
}

And I think geoclimate should be able to proceed local data by passing BBox as well. I haven't tested but since the config file is organised as it is, I'm not sure it works ...

Proposed structure and ability -use of BDTOPO with BBox) :

"input": {
        "folder": {
            "path": "C:\\mydirectory\\Geoclimate\\BD_TOPO_v2"
        },
       "locations":[44.143013,3.063040,44.171924,3.145437]
}

Hope it is clear enough

simogeo commented 2 years ago

Sorry; I've just seen that it is possible to use BBox with BDTOPO here : https://github.com/orbisgis/geoclimate/wiki/Bounding-box-case-for-Windows#bounding-box-method-with-bdtopo-v22

And I see data as to be in meters in that case ... But I maintain locations should be at path level !

ebocher commented 2 years ago

It seems reasonable

ebocher commented 2 years ago

@j3r3m1 ready for you ?

j3r3m1 commented 2 years ago

@j3r3m1 ready for you ?

Sure ! As long as we do not forget to update the wiki whenever it is changed ! =)

ebocher commented 2 years ago

Done