orbisgis / geoclimate

Geospatial processing toolbox for environmental and climate studies
GNU Lesser General Public License v3.0
59 stars 16 forks source link

Introduce several changes on geoclimate #762

Closed ebocher closed 2 years ago

ebocher commented 2 years ago
j3r3m1 commented 2 years ago
* use postfix instead of prefix to set a unique name for the output results. Indeed sometimes prefix is empty

Is this really useful ? The prefix is used to distinguish two calculations. Using postfix makes it difficult to debug sometimes since it is difficult to know which is the last one. Moreover, it could lead to enormous databases if the database is not deleted regularly.

ebocher commented 2 years ago

I' d like to said. Absolutely yes ,-) Imagine you are running a workflow on two locations. Currently and for a few tables, the name of the ouput table is the same, this is the case for INPUT_ROAD. So you can't keep in the H2GIS database, the input_road table for both locations. Only the last one will be stored. This PR fixes this issue for all all output tables computed by the workflows.

j3r3m1 commented 2 years ago

Can't the location being included in the prefix ?

ebocher commented 2 years ago

Yes this will require some code and tests. but this does not solve the problem of tables with the same names. Or the user has to put a prefix by himself, which is very heavy.

ebocher commented 2 years ago

Note that you can easly get the name of tables when a workflow is finished e.g process.getResults().output["Pont-de-Veyle"]["roadTrafficTableName"]

j3r3m1 commented 2 years ago
Bonjour,
Je suis actuellement absent du bureau jusqu'au 15 octobre.
Cordialement,
Jérémy
--
Hi,
I am actually out of office up to October the 15th.
Best regards,
Jérémy