orbisgis / geoclimate

Geospatial processing toolbox for environmental and climate studies
GNU Lesser General Public License v3.0
59 stars 16 forks source link

Reorganize module WorkflowGeoIndicators.groovy #787

Closed j3r3m1 closed 1 year ago

j3r3m1 commented 1 year ago

This PR will reorganize the module WorkflowGeoIndicators in order to simplify the use of individual workflows in the future and to facilitate the use of own RSU by users.

j3r3m1 commented 1 year ago

Remains two main steps which are:

Then an other PR would be to leave the possibility to skip the spatial unit creation if the user wants to use its own RSU.

j3r3m1 commented 1 year ago

@ebocher an error is obtained in the test called runBDTopoWorkflowWithSRID(). It seems the parameter snappingDistance passed to the workflow computeAllGeoindicators is null at this stage. I would have expected that in that case the default value for snappingDistance in the workflow computeAllGeoindicators() is taken by default (0.01) but it is not the case, the value is kept as null which cause SQL issue afterward.

What would be the best solution to solve that ? As a simple fix I can modify (add) the value of snappingDistance in the test but you might have a more generic way to solve it ?