orbisgis / geoclimate

Geospatial processing toolbox for environmental and climate studies
GNU Lesser General Public License v3.0
59 stars 16 forks source link

Add new exact indicators at grid scale #846

Closed ebocher closed 11 months ago

ebocher commented 11 months ago

Here the list

@j3r3m1 @MGousseff

ebocher commented 11 months ago

The HEIGHT_OF_ROUGHNESS_ELEMENTS is not yet available because the effectiveTerrainRoughnessLength algorithm must be replaced by frontalAreaIndexDistribution to compute its exact value.

ebocher commented 11 months ago

To limit the number of calls to basic geometric functions such as area, I suggest calculating them when the data is formatted. e.g building layer must contains a column name area, perimeter...

ebocher commented 11 months ago

projectedFacadeAreaDistribution and frontalAreaIndexDistribution do not used the same notation for the result columns.

The first one use XX_INDEX_H50_D0_30 and the second one XX_INDEXH50${layer_top}_D0_30

See : https://github.com/orbisgis/geoclimate/blob/master/geoindicators/src/main/groovy/org/orbisgis/geoclimate/geoindicators/RsuIndicators.groovy#L1940

j3r3m1 commented 11 months ago

The first one use XX_INDEX_H50_D0_30 and the second one XX_INDEXH50${layer_top}_D0_30

Seems more relevant to use the second notation: even though it induces longer column names, it is probably simpler to collect informations such as deltaH in the interval in the second case. Should we create an issue to solve this problem ?

ebocher commented 11 months ago

Here we are ;-)