orbisgis / geoclimate

Geospatial processing toolbox for environmental and climate studies
GNU Lesser General Public License v3.0
59 stars 16 forks source link

Building missing in OSM #859

Closed j3r3m1 closed 10 months ago

j3r3m1 commented 11 months ago

I have found a cinema which is not seen as a building by GeoClimate while I suppose it exists.

It is the Pathe Wilson, tagged in OSM as "amenity:cinema". Should we add this one in the buildingParam.json file ?

Note that Google images show an older version of the cinema (Gaumont at that time). The image is more than 10 years old... But I suppose the building has not changed a lot. And it is represented as a building in OSM.

j3r3m1 commented 11 months ago

Same for "building:theatre" or "amenity:theatre": https://www.openstreetmap.org/way/41968655

j3r3m1 commented 11 months ago

Some other buildings (such as this one and surroundings) but this time the reason of the absence is probably due to the zindex equal to -0.5... I know we have not considered buildings underground when zindex = -1 but I wonder whether we need to keep it for zindex=0.5 since they are slightly above ground (see [here](their top being the top of the stairs)).

In my opinion we should not consider them because they are very low above ground but is can be discussed.

@ebocher @wurtzj what do you think ?

j3r3m1 commented 11 months ago

A new one missing in OSM. It seems we do not get it since we use in buildingParams "building:market_place" instead of "building:marketplace" (however "building:marketplace" is not an existing combination for building: https://wiki.openstreetmap.org/wiki/FR:Key:building?uselang=fr but "marketplace" is a value for amenity)

j3r3m1 commented 10 months ago

Some other buildings (such as this one and surroundings) but this time the reason of the absence is probably due to the zindex equal to -0.5... I know we have not considered buildings underground when zindex = -1 but I wonder whether we need to keep it for zindex=0.5 since they are slightly above ground (see [here](their top being the top of the stairs)).

In my opinion we should not consider them because they are very low above ground but is can be discussed.

@ebocher @wurtzj what do you think ?

@wurtzj it seems this big building is more complex than what we have faced now. And the way it has been created in OSM is not consistent with OSM recommandations (levels should not be -0.5 for example). However, this building area remains complex and our current code would not allow its consideration even though it would be correctly fullfilled. It has to be taken into account in future GeoClimate version if we want to deal with complex building stuctures such as podium and other types that are met in areas such as Hong-Kong (cf. #770). Let's consider this is a part of issue #770. This issue will then be solved once the three other cases are OK.

wurtzj commented 10 months ago

Hello @j3r3m1, I read this about half levels : 'There is also an ongoing discussion on usage of fractional values, e.g. level=0.5 or level=1.5 for mezzanine floors and staircases. See the proposals for more examples. '

The complexity of such buildings seems difficult to take into account and to characterise. It seems there is a lack from additionnal informal for fully characterise such buildings. Fortunately there are not so numerous.

ebocher commented 10 months ago

Fixe this https://www.openstreetmap.org/node/5549907184

Result :

geoms

Note : There is on OSM raw a building tagged as apartements and also as a fountain ;-)

ebocher commented 10 months ago

Done for https://www.openstreetmap.org/way/41968655

geoms

ebocher commented 10 months ago

Done : https://www.openstreetmap.org/way/52498735#map=16/43.6413/1.4329

geoms

j3r3m1 commented 10 months ago

Supernice !