"areaTypeAndComposition" should be fullfilled with more types

j3r3m1 commented 9 months ago

Currently, when we make the GeoClimate calculations, only a small fraction of the buildings are considered in the TypeProportion process (https://github.com/orbisgis/geoclimate/blob/ffa10ae81e498a75f33789f20c14b64aa3dbf167/geoindicators/src/main/groovy/org/orbisgis/geoclimate/geoindicators/GenericIndicators.groovy#L677). The default values considered are given at the following line: https://github.com/orbisgis/geoclimate/blob/ffa10ae81e498a75f33789f20c14b64aa3dbf167/geoindicators/src/main/groovy/org/orbisgis/geoclimate/geoindicators/WorkflowGeoIndicators.groovy#L372

We should definitely extend this map to at least consider the "house" keyword as a "house" fraction or include it in the "residential" type. We can add a test to check that the percentage of building taken into account is near 100%.

ebocher commented 9 months ago

Note sure to understand but we compute the fractions for

["light_industry": ["light_industry"],
 "heavy_industry": ["heavy_industry"],
"commercial"    : ["commercial"],
"residential"   : ["residential"]]

So you want to separate house from residential ?

j3r3m1 commented 8 months ago

@wurtzj

which building types are used in TEB ?
would you be more interested by the building type or the building use (or both) ? Here are the possible type: https://github.com/orbisgis/geoclimate/wiki/Building-layer#type-and-main_use-column-values (we can gather them into main categories)
do you want the fraction of each type based on the building area or building floor area ?

j3r3m1 commented 8 months ago

OK, we still have to define what are the "main" types (@wurtzj). The idea is then to directly create a new attribute at building input scale which will gather some of the existing types into a more generic one.

wurtzj commented 8 months ago

Hi @j3r3m1 @ebocher

What is the difference between building area and building floor area ? walls ? number of levels ? I would rather say we need the fraction of each use. So if there are commercial activities on first floor, and residential on other floors, then a fraction of each is ideal.

TEB deal with building usage with an approach is similar to a tile approach with flux aggregation (e.g. using TEB for urban areas and ISBA for rural areas and aggregate fluxes towards the atmosphere), but the tiles here represent different building uses and human behaviours and the fluxes towards the building envelope (wall and roof) and the outdoor air are aggregated.

In TEB we use these types :

Fraction of individual housing building use

Fraction of collective housing building use

Fraction of commercial building use

Fraction of tertiary building use

Fraction of industrial building use

Fraction of non heated buildings

Fraction of low-rise building

Fraction of mid-rise building

Fraction of high-rise building

Fraction of activity buildings

Fraction of households with high Equipment-Intensity-of- Use, collective housing

Fraction of households with low Equipment-Intensity-of- Use, individual housing

Fraction of households with low Equipment-Intensity-of- Use, collective housing

Fraction of households with high Energy Control Behaviour, individual housing

Fraction of households with high Energy Control Behaviour, collective housing

Robert Schoetter has already done some aggregation scripts to adapt the output of Geoclimate to TEB. I can send it to you if you need.

j3r3m1 commented 8 months ago

So if there are commercial activities on first floor, and residential on other floors, then a fraction of each is ideal. For now I am afraid we will not have such degree of detail. But at least I see that the right indicator is the fraction of building floor area for each type.

Thank you for sharing these informations. Even though you might have existing process to connect the GeoClimate output to these inputs, I try to see what would be the best using the current data we have as input

[ ] Fraction of individual housing building use : sounds like fraction of "house" or "detached" or "bungalow" or "farm", "villa", "terrace"
[ ] Fraction of collective housing building use : "apartments","barracks","abbey", "dormitory", "sheltered_housing", "workers_dormitory", "condominium" --> we will also have a residential fraction where we do not have more info about the type
[ ] Fraction of commercial building use : "commercial","internet_cafe","money_transfer","pharmacy","post_office","cinema","arts_centre", "brothel", "casino","sustenance","hotel","restaurant","bar","cafe","fast_food","ice_cream","pub","aquarium"
[ ] Fraction of tertiary building use: "government", "townhall", "retail","gambling","music_venue", "nightclub" "shop","store","supermarket","office","terminal","airport_terminal","bank","bureau_de_change","boat_rental","car_rental","research_institute","community_centre", "conference_centre","events_venue","exhibition_centre","social_centre","studio","theatre","library","healthcare",entertainment_arts_culture","hospital", "information"
[ ] Fraction of education building use: "education","swimming-pool", "fitness_centre","sports_centre","college","kindergarten","school","university","museum","gallery"
[ ] Fraction of light industrial building use: "light industrial"
[ ] Fraction of heavy industrial building use: "heavy industrial"
[ ] Fraction of non heated buildings: "silo", "barn", "cowshed","ruins","church","chapel","military","castle","monument","fortress","synagogue","mosquee","musalla","shrine","cathedral", "agricultural", "farm_auxiliary","digester","horse_riding","stadium","track","pitch", "ice_rink","sports_hall","ammunition","bunker","casemate","shelter","religious","place_of_worship","wayside_shrine","station","stable","sty","greenhouse","kiosk","marketplace","marker","warehouse","planetarium","fire_station","water_tower","grandstand","transportation","toll_booth",
[ ] Fraction of low-rise building: the outputs from "roofFractionDistributionExact" should be used (histogram of building heights)
[ ] Fraction of mid-rise building: the outputs from "roofFractionDistributionExact" should be used
[ ] Fraction of high-rise building: the outputs from "roofFractionDistributionExact" should be used
[ ] Fraction of activity buildings: I have no idea what this could be ?

I think the three following are based on a combination of the GeoClimate outputs + informations about the population. It would be good to know what they are anyway to be sure that the definition of our indicator is still the same.

[ ] Fraction of households with high Equipment-Intensity-of- Use, collective housing
[ ] Fraction of households with low Equipment-Intensity-of- Use, individual housing
[ ] Fraction of households with low Equipment-Intensity-of- Use, collective housing
[ ] Fraction of households with wigh Energy Control Behaviour, individual housing
[ ] Fraction of households with high Energy Control Behaviour, collective housing

After that we still have quite a lot of information about building types which is not used. It is not a problem but maybe you would like some of them belong to a specific category above. You can have a look at the main use and type table and tell us: https://github.com/orbisgis/geoclimate/wiki/Building-layer#type-and-main_use-column-values

j3r3m1 commented 6 months ago

We need to update the type and main use with the "raw OSM data". Once it is done, we need to update the GeoClimate doc to say:

that types and main uses are directly the ones from OSM with their definition (removing other tables)
that aggregation of type are documented in the output indicators tables (LCZ and thermal energy indicators related)