orbisgis / geoclimate

Geospatial processing toolbox for environmental and climate studies
GNU Lesser General Public License v3.0
59 stars 15 forks source link

Management of building height wall = null or = 0 #907

Open j3r3m1 opened 7 months ago

j3r3m1 commented 7 months ago

Currently, there is no way to pass to the formatHeightAndNbLevels() function a building height wall equal to null while it should be the case. The current fix is to set building height wall equal to 0. This is the case at the beginning of the BDTopo processing chain but also in the OSM workflow once we have estimated the building height. We should manage this problem creating a new "if case" in the formatHeightAndNbLevels() but this will probably induce many modifications in the code for BDTopo.

The advantage of having this differenciation between 0 and null is that some (rare) buildings have a "triangular" section (roof up to the ground) and thus should have height_wall = 0. But beforehand, we should also check that such modification will not affect the way we define the number of level (is the number of level defined by the building height roof or building height wall ?...).