orbisgis / geoclimate

Geospatial processing toolbox for environmental and climate studies
GNU Lesser General Public License v3.0
59 stars 16 forks source link

Missing buildings using GeoClimate Tools #997

Open sachabaclet opened 1 month ago

sachabaclet commented 1 month ago

Hi,

I have used GeoClimate_Tools-1.0.1 to extract the buildings in the city of Tartu (Estonia). However, I noticed that some buildings were missing from the output building.geojson file.

You can see in the following image the buildings extracted by the tools in pink and the missing buildings in blue.

image

ebocher commented 1 month ago

Hi @sachabaclet

Please share the json file you are using with GeoClimate so we can debugg it.

Thanks

sachabaclet commented 1 month ago

Here is the geojson file generated by GeoClimate Tools: building.zip

ebocher commented 1 month ago

Oupsss I mean the GeoClimate json config file.

sachabaclet commented 1 month ago

I am using the tool by Samuel Marsault, so this may be what you are looking for: https://github.com/Universite-Gustave-Eiffel/plamade/blob/osm/src/main/groovy/GeoClimate_Script_CL.groovy

j3r3m1 commented 1 month ago

Thank you for reporting. Here are the reasons:

  1. GeoClimate limitations:

  2. OSM (or data related) reasons:

wurtzj commented 1 month ago

Hello @j3r3m1,

I think tents should not be added for the moment has it has no thermal inertia, even if it is impervious (which will be considered as road in meteorological models).

pierromond commented 1 month ago

Hello @wurtzj ,

For the acoustic use of geoclimate is important to use every buildings... Maybe a option could be added ?

Best

wurtzj commented 1 month ago

Maybe it could be added in an additional class ? TENT_FRACTION ?

pierromond commented 1 month ago

Oww sorry I didn't see it was about tents ! ... I read too fast. For acoustic use, the tent may not be in extracted buildings !

ebocher commented 1 month ago

Good job inspecteur @j3r3m1 ! GeoClimate's model must satisfy as many uses as possible. Let's take our time before fixing this issue ;-)

wurtzj commented 1 month ago

Hello @j3r3m1 and @ebocher ,

Does Geoclimate take into account building=warehouse ? It seems to me it is lacking.

Cheers,

Jean

j3r3m1 commented 1 month ago

Do you have test cases where you observed or suppose it might be missing ? Because it should normally work if the building has the key:value "building:warehouse" (cf. https://github.com/orbisgis/geoclimate/blob/master/osm/src/main/resources/org/orbisgis/geoclimate/osm/buildingParams.json)

wurtzj commented 1 month ago

Capture d’écran du 2024-10-03 13-42-56 Here is a harbour near Seine river. Building fraction is 14% but looking at Open Street Map it seems higher to me. But Maybe I'm wrong ? Capture d’écran du 2024-10-03 13-44-10

j3r3m1 commented 1 month ago

Not sure I understand the issue. Is the building fraction too low or the fraction of warehouse building ? Because most of the building do not have a tag then they get the tag of the area they are located in (which is industrial). Then there should be a large proportion of industrial buildings I suppose

wurtzj commented 1 month ago

Yes to me building fraction is underestimated. But building fraction do include industrial building ?

j3r3m1 commented 1 month ago

Yes of course industrial buildings are considered in the building fraction. Here is the data at RSU scale. I do not think the building fraction is wrong, even though there is a quite high spatial variability.

imageimage image

wurtzj commented 1 month ago

Ok good to know. I think it is a cognitive bias from my side then. Thanks !

j3r3m1 commented 1 month ago

I am going to test if we get all buildings from the zone anyway, we might have forgotten some tags (I know understand that it was your initial question...), do not close it yet.

j3r3m1 commented 1 month ago

We might think that there are several missing buildings in the area (cf. below) image image

But actually most of the polygons that look like buildings are construction zones or brownfields and their color is slightly different than the buidings. There is a single building that is missing and need to be added but it is tiny (https://www.openstreetmap.org/way/796915590). Its tag is "building":"storage_tank".

wurtzj commented 1 month ago

Thanks for checking ! :)