tri review - Githubissues

orbislabs / cmp

An IAB compliant CMP, with user privacy preserving features.

1 stars 0 forks source link

tri review #68

Open juji opened 6 years ago

juji commented 6 years ago

My reviews are mostly about promise, and the use of async.

Other than that:

prevent the script from running when window doesn't exists
prevent using window.cmp
use a param in tagManagerModule