orbital-systems / react-native-esp-idf-provisioning

ESP IDF provisioning and custom data library for react-native
MIT License
26 stars 6 forks source link

Security setting should be validated when connecting #46

Open mateogianolio opened 9 months ago

mateogianolio commented 9 months ago

They implement the security check in the example app after connecting (https://github.com/espressif/esp-idf-provisioning-android/blob/master/app/src/main/java/com/espressif/ui/activities/AddDeviceActivity.java#L699-L753) but not in the library itself. So if you try to connect to an ESP device configured with security level 1 or 2 using ESPSecurity.unsecure it will not give you an error until later, which can be very confusing/frustrating.