search

orbitalci / orbital

Orbital is a self-hosted CI system for solo/small consulting dev teams. Written in Rust.
GNU General Public License v3.0
29 stars 2 forks source link

signaler_actions.go references bitbucket, even if repository is type Github #193

Closed eccramer closed 4 years ago

eccramer commented 5 years ago

I was trying to configure my ocelot dev instance to build a github repo, and I'm running into an error. The important thing is that the error message it gave me references bitbucket.

Error message exists in router/admin/signaler_actions.go on line 136.

eccramer-mbp:ocelot evancramer$ grep -nr "Could not get bitbucket" .
./router/admin/signaler_actions.go:136:                 err = status.Error(codes.InvalidArgument, "Could not get bitbucket ocelot.yml. Error: "+err.Error())
eccramer-mbp:ocelot evancramer$

We should change this to either detect the repo type, and print that, or just genericize the error.