search

orbitalci / orbital

Orbital is a self-hosted CI system for solo/small consulting dev teams. Written in Rust.
GNU General Public License v3.0
29 stars 2 forks source link

Audit all protos #206

Closed tjtelan closed 5 years ago

tjtelan commented 5 years ago

The intention is to methodically walk through each of our protobuf files and then rebuild connections after there is an agreement for the consistency and scalability.

We should create a branch off master (let's call it refactor-protos) and do refactoring for protos there. PRs will be against this branch, and there will be no expectation of code building.

Add the link to issues that track refactor for these protos

181 - creds.proto

build.proto creds.proto guideocelot.proto storage.proto vcshandler.proto werkerserver.proto

bitbucket/common.proto bitbucket/commonevententities.proto bitbucket/diffstat.proto bitbucket/projectrootdir.proto bitbucket/respositories.proto bitbucket/webhook.proto

github/error.proto github/hooks.proto

slack/slack.proto

tjtelan commented 5 years ago

Directory structure needs to reflect the dependency import relationship!

tjtelan commented 5 years ago

We're going through this exercise, but I don't know that I agree with this process anymore. It is really administrative. Will get through everything through PRs.