orbitalci / orbital

Orbital is a self-hosted CI system for solo/small consulting dev teams. Written in Rust.
GNU General Public License v3.0
29 stars 2 forks source link

NO_USE_TLS=false does not have the same effect as NO_USE_TLS being unset #216

Closed tjtelan closed 4 years ago

tjtelan commented 5 years ago

This was tested with several of the ocelot cli versions we have floating around.


If NO_USE_TLS=false, we would expect ocelot summary to work, and to use TLS.

$ export NO_USE_TLS=false
$ echo ${NO_USE_TLS:-No value}
false
$ ocelot summary
Flag -acct-repo was not set, detecting account and repository using git commands
Detected <account>/<repo> of level11consulting/mobile_log_viewer_react
Could not connect to server! Admin location is ocy-admin-grpc.metaverse.l11.com:443

For absence of doubt, we expect this is fail if NO_USE_TLS=true

$ export NO_USE_TLS=true
$ echo ${NO_USE_TLS:-No value}
true
$ ocelot summary
Flag -acct-repo was not set, detecting account and repository using git commands
Detected <account>/<repo> of level11consulting/mobile_log_viewer_react
Could not connect to server! Admin location is ocy-admin-grpc.metaverse.l11.com:443

Everything is good when NO_USE_TLS is unset, and we intend to use TLS.

$ unset NO_USE_TLS
$ echo ${NO_USE_TLS:-No value}
No value

$ ocelot summary
Flag -acct-repo was not set, detecting account and repository using git commands
Detected <account>/<repo> of level11consulting/mobile_log_viewer_react

+----------+-------------------------+--------------------------+--------------------+--------+--------+------------------------------------------+
| BUILD ID |          REPO           |      BUILD DURATION      |     START TIME     | RESULT | BRANCH |                   HASH                   |
+----------+-------------------------+--------------------------+--------------------+--------+--------+------------------------------------------+
| 2975     | mobile_log_viewer_react | 4 minutes and 15 seconds | Mon Apr 8 13:24:34 | PASS   | master | ebbf1127a88a9d4e6f25e9caf905efbbaf6c6efb |
+----------+-------------------------+--------------------------+--------------------+--------+--------+------------------------------------------+
tjtelan commented 4 years ago

This is a cli bug that will stay with ocelot. Closing.