search

orbitalci / orbital

Orbital is a self-hosted CI system for solo/small consulting dev teams. Written in Rust.
GNU General Public License v3.0
29 stars 2 forks source link

Move werker's startup tar files out of L11 S3 and into Github #218

Closed tjtelan closed 4 years ago

tjtelan commented 5 years ago

This has almost been deleted once or twice. https://github.com/level11consulting/orbitalci/blob/master/server/grpc/werker/werker_ws_stream.go#L42

I'd probably like an evaluation of whether we even need this, since it isn't clearly documented what this contains. Just that "spawned containers need" it.

If we do, serving runtime dependent files from Github is slightly more reliable, and maintainable than some random org's public S3 bucket.

tjtelan commented 5 years ago

In addition to the runtime being dependent on Level11's S3 bucket, the tar file includes several scripts that are not versioned in the codebase.

$ tar xvf werker_files_dev.tar
x bb_download.sh
x get_ssh_key.sh
x install_deps.sh
x render_aws.sh
x render_docker.sh
x render_kubeconfig.sh
x render_mvn.sh

We absolutely need to find a different way to handle this.

A short term goal would be to template the files and instead of downloading them from S3, we could write them into the container's filesystem. Not ideal, but it is at least one less concern.