search

orbitalci / orbital

Orbital is a self-hosted CI system for solo/small consulting dev teams. Written in Rust.
GNU General Public License v3.0
29 stars 2 forks source link

Remove credentials_id from polling_repos #220

Closed tjtelan closed 4 years ago

tjtelan commented 5 years ago

This is a reminder to my future self. In production, I've rolled back the version we're running back to 0.7.3 and 0.7.31 (on poller and werker).

This means that we have extra columns still in postgresql that aren't being used. Specifically, table polling_repo has an extra column credentials_id that is also NOT NULL. Or at least, it was NOT NULL until I changed it to be nullable.

This change was necessary to re-enable our ability to add new polling schedules. Since all our sql queries select columns by name, it seems to work out w/o removing the column.

tjtelan commented 5 years ago

It wasn't enough to remove these columns. There were a bunch of other functions that needed to be modified to no longer pass pb.SignaledBy and credentials_id.

I was able to make a few of these changes in another branch that has a bunch of other changes. https://github.com/tjtelan/orbitalci/commit/6c1766e51bd78ab4e7c53d30de0bc4c4550e0cdb

We probably want a PR from a different branch though.