search

orbitalci / orbital

Orbital is a self-hosted CI system for solo/small consulting dev teams. Written in Rust.
GNU General Public License v3.0
29 stars 2 forks source link

Agent & AgentBuilder structs that converts to/from proto and diesel types #246

Closed tjtelan closed 4 years ago

tjtelan commented 4 years ago

I want to tighten up From traits between proto and diesel types so I can use standard data structures and builder patterns in my business logic and leave the Tonic + Prost stuff strictly for interacting with gRPC.

tjtelan commented 4 years ago

My thoughts on this specific approach are still changing since I started refactoring the build event from a single procedure into an event loop and a finite state machine.

I don't have any new solutions to offer. Just a feeling that I need these interactions to support local development, and local-only builds that may not interact with an orbital grpc server.

tjtelan commented 4 years ago

Closing. I'm going to give this a little more thought w/ respect to implementation. My state machine implementation introduces another internal type w/ respect to build state for converting to proto, but I'm still using the diesel types directly whenever possible, since that was sort of the initial goal.