search

orbitalimpact / hipmost

Migrate your Hipchat history to Mattermost
MIT License
10 stars 5 forks source link

Private Message Import Improvements #7

Closed davidbartonau closed 5 years ago

davidbartonau commented 5 years ago

Some improvements for overlength messages. My comment also says I redid @heuri fix, but repulling made that comment invalid.

ylluminarious commented 5 years ago

@davidbartonau Sorry for the delayed response. It's been a somewhat hectic past few days. I don't have time to test this right now, but I trust that you already did so I'm going to go ahead and merge. Everything looks okay to me... ping @gabrielrios in case you want to take a look.

Also, we tend to use under_scores instead of camelCase. But it's not a big deal; I'm just telling you for future reference. We probably should have some sort of style file, so it's really our own fault.

Lastly: thank you so much for the contribution! We appreciate it!