search

orbitalquark / textadept-file-diff

Two-way file comparison module for Textadept.
MIT License
12 stars 1 forks source link

Do we really need to compile the tests? #2

Open paaguti opened 1 year ago

paaguti commented 1 year ago

Would it be possible to avoid compiling/running the tests? They are really expensive time-wise.

orbitalquark commented 1 year ago

I noticed that too. CMake seems to run diff-match-patch's CMake build too. There's probably a way to avoid it completely since only the header file is needed for this module.

paaguti commented 1 year ago

Hi,

I went back to the sources of diff-match-patch and found out that they have a Lua version. Currently fiddling around a bit with it to see if a pure Lua version is feasible (which I think it is) This would greatly alliviate the situation and Win1x and macOS. My current Win1x (yes, I know... I would rather not have to be on it) started complaining about the distributed diff.dll

On Thu, 29 Dec 2022 at 16:00, orbitalquark @.***> wrote:

I noticed that too. CMake seems to run diff-match-patch's CMake build too. There's probably a way to avoid it completely since only the header file is needed for this module.

— Reply to this email directly, view it on GitHub https://github.com/orbitalquark/textadept-file-diff/issues/2#issuecomment-1367390594, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAZKU4EO63MPKIY2DZETC33WPWRQLANCNFSM6AAAAAATL35INU . You are receiving this because you authored the thread.Message ID: @.***>

-- Fragen sind nicht da um beantwortet zu werden, Fragen sind da um gestellt zu werden Georg Kreisler

Headaches with a Juju log: unit-basic-16: 09:17:36 WARNING juju.worker.uniter.operation we should run a leader-deposed hook here, but we can't yet

orbitalquark commented 1 year ago

Originally I used the pure Lua version, but it was really slow, so I had to fall back on the C++ version. Obviously that hurts from a portability perspective :(

orbitalquark commented 1 year ago

I'm dumb. I initially realized this, but I forgot that I updated the GitHub Actions build script to only build for the "diff" target: cmake --build build --config Release --target diff -j. That will only build the module. From the build directory you should also just be able to run make diff if you're using CMake's Makefile generator.

paaguti commented 1 year ago

OK, anyhow I made it... just to make sure that I can use it without having the OS complaining. Take a look in my GitHub ;-) seems to work and, BTW, doesn't look that slow on files the size I normally use. These include the Textadept12 theme generator in Theme Creator (already in my GitHub too)

Happy New Year